组织优秀代码的四原则

代码写了5年,必然会产生审丑疲劳,代码混乱不堪,无法维护,可阅读性基本没有。面对种种的问题,如何使代码更优雅,更具可读性便成了迫切需要解决的问题。下面我从实战中总结了四项基本原则,只要你灵活运用,我保证你的代码绝对漂亮的让自己不敢相信。下面我尝试以一种教学的方式教给你这四项基本原则。

一、把代码按逻辑相关性分成不同的段落,亮点是每个段落可以给个总结性的注释

我们可能都写过作文,试想一下,如果一篇文章没有任何分段,一气呵成,你阅读之后会有什么感想?会不会想杀了作者?

其实,码代码和写文章是可以类比的,如果你写得代码中没有任何分段,对于代码阅读者来说难道不是地狱吗?可能语言的描述终究是太抽象,那我就呈上两个例子让大家吐槽一下吧。
示例1:

public interface FrontendServer {
    void viewProfile(HttpRequest request);
    void openDatabase(String location,String user);
    void saveProfile(HttpRequest request);
    String extractQueryParam(HttpRequest request,String param);
    void replyOK(HttpRequest request,String html);
    void findFriends(HttpRequest request);
    void replyNotFound(HttpRequest request,String error);
    void closeDatabase(String location);
}

示例2:

# Import the user's email contracts, and match them to users in our system.
# Then display a list of those users that he/she isn't already friends with.
def suggest_new_friends(user,email_password):
    friends = user.friends()
    friend_emails = set(f.email for f in friends)
    contacts = import_contacts(user.email,email_password)
    contact_emails = set(c.email for c in contacts)
    non_friend_emails = contact_emails-friend_emails
    suggested_friends = User.objects.select(email_in=non_friend_emails)
    display['user'] = user
    display['friends'] = friends
    display['suggested_friends'] = suggested_friends
    return render("suggested_friends.html",display)

吐槽时间。。。

尝试使用一下我们的代码分段原则,闪亮的结果如下:

示例1应用原则一:

public interface FrontendServer {
    // Handlers
    void viewProfile(HttpRequest request);
    void saveProfile(HttpRequest request);
    void findFriends(HttpRequest request);

    // Request/Reply Utilities
    String extractQueryParam(HttpRequest request,String param);
    void replyOK(HttpRequest request,String html);
    void replyNotFound(HttpRequest request,String error);
    
    // Database Helpers
    void openDatabase(String location,String user);
    void closeDatabase(String location);
}

示例2应用原则一:

# Import the user's email contracts, and match them to users in our system.
# Then display a list of those users that he/she isn't already friends with.
def suggest_new_friends(user,email_password):
    # Get the user's friends' email addresses.
    friends = user.friends()
    friend_emails = set(f.email for f in friends)

    # Import all email addresses from this user's email account.
    contacts = import_contacts(user.email,email_password)
    contact_emails = set(c.email for c in contacts)

    # Find matching users that  they aren't already friends with.
    non_friend_emails = contact_emails-friend_emails
    suggested_friends = User.objects.select(email_in=non_friend_emails)

    @ Display these lists on the page.
    display['user'] = user
    display['friends'] = friends
    display['suggested_friends'] = suggested_friends
    
    return render("suggested_friends.html",display)

二、使用一致的布局,让相似的代码看起来相似

你要问我为什么让相似的代码看起来相似会使代码更清晰更容易理解,我竟然无言以对。自以为可能是人类的认知原理导致的,我无法给出更官方的解释,但是我可以给你几个例子让你好好体会一下如果不这么做带来的后果。
示例1:

public class PerformanceTester {
    public static final TcpConnectionSimulator wifi = new TcpConnectionSimulator(
            500, /* kpbs */
            80, /* millisecs latency */
            200, /* jitter */
            1 /* packet loss % */);
    public static final TcpConnectionSimulator t3_fiber =
            new TcpConnectionSimulator(
                500, /* kpbs */
                80, /* millisecs latency */
                200, /* jitter */
                1 /* packet loss % */);
    public static final TcpConnectionSimulator cell = new TcpConnectionSimulator(
            100, /* kbps */
            400, /* millisecs latency */
            250, /* jitter */
            5 /* packet loss % */);

}

我们使用原则二来变化示例1,结果如下:

public class PerformanceTester {
    public static final TcpConnectionSimulator wifi = 
            new TcpConnectionSimulator(
            500, /* kpbs */
            80,  /* millisecs latency */
            200, /* jitter */
            1    /* packet loss % */);
    public static final TcpConnectionSimulator t3_fiber =
            new TcpConnectionSimulator(
            500, /* kpbs */
            80,  /* millisecs latency */
            200, /* jitter */
            1    /* packet loss % */);
    public static final TcpConnectionSimulator cell = 
            new TcpConnectionSimulator(
            100, /* kbps */
            400, /* millisecs latency */
            250, /* jitter */
            5    /* packet loss % */);

}

变换的结果很让人眼前一亮,但还不是很完美,通过原则三,会将完美进行到极致。我们首先介绍一下原则三。

三、使用方法或者其他技术消除重复的代码

消除代码块中重复的代码,会使得代码逻辑更加简洁清晰,更具表达性,重点更加突出。
示例1:

public class PerformanceTester {
    public static final TcpConnectionSimulator wifi = 
            new TcpConnectionSimulator(
            500, /* kpbs */
            80,  /* millisecs latency */
            200, /* jitter */
            1    /* packet loss % */);
    public static final TcpConnectionSimulator t3_fiber =
            new TcpConnectionSimulator(
            500, /* kpbs */
            80,  /* millisecs latency */
            200, /* jitter */
            1    /* packet loss % */);
    public static final TcpConnectionSimulator cell = 
            new TcpConnectionSimulator(
            100, /* kbps */
            400, /* millisecs latency */
            250, /* jitter */
            5    /* packet loss % */);

示例1应用原则三:

public class PerformanceTester {
    // TcpConnectionSimulator(throughput, latency, jitter, packet_loss)
    //                            [Kbps]   [ms]    [ms]    [percent]   
    
    public static final TcpConnectionSimulator wifi =
            new TcpConnectionSimulator(500, 80, 200, 1);
    public static final TcpConnectionSimulator t3_fiber =
            new TcpConnectionSimulator(500, 80, 200, 1);
    public static final TcpConnectionSimulator cell =
            new TcpConnectionSimulator(100, 400, 250, 5);
}

示例2:

 DatabaseConnectio database_connection;
    string error;
    assert(expandFullName(database_connection,"Doug Adams",&error)=="Mr. Douglas Adams");
    assert(error == "");   
    assert(expandFullName(database_connection,"No Such Guy",&error)=="");
    assert(error =="no match found");   
    assert(expandFullName(database_connection,"John",&error)=="");
    assert(error =="more than one result");

示例2应用原则三:

    checkFullName("Doug Adams","Mr. Douglas Adams","");
    checkFullName("Jake Brown","Mr. Jake Brown III","");
    checkFullName("No Such Guy","","no match found");
    checkFullName("John","","more than one result");

    void checkFullName(String partial_name,
                       String expeted_full_name,
                       String expected_error){
        // database_connection is now a class member
        String error;
        String full_name = expandFullName(database_connection,partial_name,&error);
        assert(error == expected_error);
        assert(full_name == expeted_full_name);
    }

四、使用列对齐来使代码更加易读

使用列对齐的方式组织代码,可以让语句之间的对应关系清晰明显,阅读者从中很容易获取方法的调用规则等信息,这对于理解代码和发现代码中的错误有极大帮助。

示例1:

    checkFullName("Doug Adams","Mr. Douglas Adams","");
    checkFullName("Jake Brown","Mr. Jake Brown III","");
    checkFullName("No Such Guy","","no match found");
    checkFullName("John","","more than one result");

示例1应用原则四:

    checkFullName("Doug Adams"  , "Mr. Douglas Adams"  , "");
    checkFullName("Jake Brown"  , "Mr. Jake Brown III" , "");
    checkFullName("No Such Guy" , ""                   , "no match found");
    checkFullName("John"        , ""                   , "more than one result");

示例2:

# Extract POST parameters to local variables
details = request.POST.get('details')
location = request.POST.get('location')
phone = request.POST.get('phone')
email = request.POST.get('email')
url = request.POST.get('url')

示例2应用原则四:

# Extract POST parameters to local variables
details  = request.POST.get('details')
location = request.POST.get('location')
phone    = request.POST.get('phone')
email    = request.POST.get('email')
url      = request.POST.get('url')

如果想了解更多信息或者对开源项目感兴,请加我的微信公众号,我在那里等你

小熊的开源社区.jpg
最后编辑于
©著作权归作者所有,转载或内容合作请联系作者
  • 序言:七十年代末,一起剥皮案震惊了整个滨河市,随后出现的几起案子,更是在滨河造成了极大的恐慌,老刑警刘岩,带你破解...
    沈念sama阅读 159,117评论 4 362
  • 序言:滨河连续发生了三起死亡事件,死亡现场离奇诡异,居然都是意外死亡,警方通过查阅死者的电脑和手机,发现死者居然都...
    沈念sama阅读 67,328评论 1 293
  • 文/潘晓璐 我一进店门,熙熙楼的掌柜王于贵愁眉苦脸地迎上来,“玉大人,你说我怎么就摊上这事。” “怎么了?”我有些...
    开封第一讲书人阅读 108,839评论 0 243
  • 文/不坏的土叔 我叫张陵,是天一观的道长。 经常有香客问我,道长,这世上最难降的妖魔是什么? 我笑而不...
    开封第一讲书人阅读 44,007评论 0 206
  • 正文 为了忘掉前任,我火速办了婚礼,结果婚礼上,老公的妹妹穿的比我还像新娘。我一直安慰自己,他们只是感情好,可当我...
    茶点故事阅读 52,384评论 3 287
  • 文/花漫 我一把揭开白布。 她就那样静静地躺着,像睡着了一般。 火红的嫁衣衬着肌肤如雪。 梳的纹丝不乱的头发上,一...
    开封第一讲书人阅读 40,629评论 1 219
  • 那天,我揣着相机与录音,去河边找鬼。 笑死,一个胖子当着我的面吹牛,可吹牛的内容都是我干的。 我是一名探鬼主播,决...
    沈念sama阅读 31,880评论 2 313
  • 文/苍兰香墨 我猛地睁开眼,长吁一口气:“原来是场噩梦啊……” “哼!你这毒妇竟也来了?” 一声冷哼从身侧响起,我...
    开封第一讲书人阅读 30,593评论 0 198
  • 序言:老挝万荣一对情侣失踪,失踪者是张志新(化名)和其女友刘颖,没想到半个月后,有当地人在树林里发现了一具尸体,经...
    沈念sama阅读 34,313评论 1 243
  • 正文 独居荒郊野岭守林人离奇死亡,尸身上长有42处带血的脓包…… 初始之章·张勋 以下内容为张勋视角 年9月15日...
    茶点故事阅读 30,575评论 2 246
  • 正文 我和宋清朗相恋三年,在试婚纱的时候发现自己被绿了。 大学时的朋友给我发了我未婚夫和他白月光在一起吃饭的照片。...
    茶点故事阅读 32,066评论 1 260
  • 序言:一个原本活蹦乱跳的男人离奇死亡,死状恐怖,灵堂内的尸体忽然破棺而出,到底是诈尸还是另有隐情,我是刑警宁泽,带...
    沈念sama阅读 28,392评论 2 253
  • 正文 年R本政府宣布,位于F岛的核电站,受9级特大地震影响,放射性物质发生泄漏。R本人自食恶果不足惜,却给世界环境...
    茶点故事阅读 33,052评论 3 236
  • 文/蒙蒙 一、第九天 我趴在偏房一处隐蔽的房顶上张望。 院中可真热闹,春花似锦、人声如沸。这庄子的主人今日做“春日...
    开封第一讲书人阅读 26,082评论 0 8
  • 文/苍兰香墨 我抬头看了看天上的太阳。三九已至,却和暖如春,着一层夹袄步出监牢的瞬间,已是汗流浃背。 一阵脚步声响...
    开封第一讲书人阅读 26,844评论 0 195
  • 我被黑心中介骗来泰国打工, 没想到刚下飞机就差点儿被人妖公主榨干…… 1. 我叫王不留,地道东北人。 一个月前我还...
    沈念sama阅读 35,662评论 2 274
  • 正文 我出身青楼,却偏偏与公主长得像,于是被迫代替她去往敌国和亲。 传闻我的和亲对象是个残疾皇子,可洞房花烛夜当晚...
    茶点故事阅读 35,575评论 2 270

推荐阅读更多精彩内容